Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
Y
yii2
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
PSDI Army
yii2
Commits
ee994efd
Commit
ee994efd
authored
Jul 09, 2013
by
Qiang Xue
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
polishing debugger.
parent
a6746ed0
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
50 additions
and
32 deletions
+50
-32
Command.php
framework/yii/db/Command.php
+4
-4
DbPanel.php
framework/yii/debug/panels/DbPanel.php
+44
-26
RequestPanel.php
framework/yii/debug/panels/RequestPanel.php
+2
-2
No files found.
framework/yii/db/Command.php
View file @
ee994efd
...
@@ -275,13 +275,13 @@ class Command extends \yii\base\Component
...
@@ -275,13 +275,13 @@ class Command extends \yii\base\Component
$rawSql
=
$this
->
getRawSql
();
$rawSql
=
$this
->
getRawSql
();
Yii
::
trace
(
"Executing SQL:
$rawSql
"
,
__METHOD__
);
Yii
::
info
(
$rawSql
,
__METHOD__
);
if
(
$sql
==
''
)
{
if
(
$sql
==
''
)
{
return
0
;
return
0
;
}
}
$token
=
"SQL:
$sql
"
;
$token
=
$sql
;
try
{
try
{
Yii
::
beginProfile
(
$token
,
__METHOD__
);
Yii
::
beginProfile
(
$token
,
__METHOD__
);
...
@@ -383,7 +383,7 @@ class Command extends \yii\base\Component
...
@@ -383,7 +383,7 @@ class Command extends \yii\base\Component
$sql
=
$this
->
getSql
();
$sql
=
$this
->
getSql
();
$rawSql
=
$this
->
getRawSql
();
$rawSql
=
$this
->
getRawSql
();
Yii
::
trace
(
"Querying SQL:
$rawSql
"
,
__METHOD__
);
Yii
::
info
(
$rawSql
,
__METHOD__
);
/** @var $cache \yii\caching\Cache */
/** @var $cache \yii\caching\Cache */
if
(
$db
->
enableQueryCache
&&
$method
!==
''
)
{
if
(
$db
->
enableQueryCache
&&
$method
!==
''
)
{
...
@@ -403,7 +403,7 @@ class Command extends \yii\base\Component
...
@@ -403,7 +403,7 @@ class Command extends \yii\base\Component
}
}
}
}
$token
=
"SQL:
$sql
"
;
$token
=
$sql
;
try
{
try
{
Yii
::
beginProfile
(
$token
,
__METHOD__
);
Yii
::
beginProfile
(
$token
,
__METHOD__
);
...
...
framework/yii/debug/panels/DbPanel.php
View file @
ee994efd
...
@@ -24,10 +24,20 @@ class DbPanel extends Panel
...
@@ -24,10 +24,20 @@ class DbPanel extends Panel
public
function
getSummary
()
public
function
getSummary
()
{
{
$queryCount
=
count
(
$this
->
data
[
'messages'
])
/
2
;
$timings
=
$this
->
calculateTimings
();
$queryCount
=
count
(
$timings
);
$queryTime
=
0
;
foreach
(
$timings
as
$timing
)
{
$queryTime
+=
$timing
[
3
];
}
$queryTime
=
number_format
(
$queryTime
*
1000
)
.
' ms'
;
$url
=
$this
->
getUrl
();
$output
=
<<<EOD
$output
=
<<<EOD
<div class="yii-debug-toolbar-block">
<div class="yii-debug-toolbar-block">
<a href="$url">
DB queries: <span class="label">$queryCount</span>
DB queries: <span class="label">$queryCount</span>
time: <span class="label">$queryTime</span>
</a>
</div>
</div>
EOD;
EOD;
return
$queryCount
>
0
?
$output
:
''
;
return
$queryCount
>
0
?
$output
:
''
;
...
@@ -35,34 +45,12 @@ EOD;
...
@@ -35,34 +45,12 @@ EOD;
public
function
getDetail
()
public
function
getDetail
()
{
{
$messages
=
$this
->
data
[
'messages'
];
$timings
=
$this
->
calculateTimings
();
$timings
=
array
();
$stack
=
array
();
foreach
(
$messages
as
$i
=>
$log
)
{
list
(
$token
,
$level
,
$category
,
$timestamp
)
=
$log
;
$log
[
4
]
=
$i
;
if
(
$level
==
Logger
::
LEVEL_PROFILE_BEGIN
)
{
$stack
[]
=
$log
;
}
elseif
(
$level
==
Logger
::
LEVEL_PROFILE_END
)
{
if
((
$last
=
array_pop
(
$stack
))
!==
null
&&
$last
[
0
]
===
$token
)
{
$timings
[
$last
[
4
]]
=
array
(
count
(
$stack
),
$token
,
$last
[
3
],
$timestamp
-
$last
[
3
]);
}
}
}
$now
=
microtime
(
true
);
while
((
$last
=
array_pop
(
$stack
))
!==
null
)
{
$delta
=
$now
-
$last
[
3
];
$timings
[
$last
[
4
]]
=
array
(
count
(
$stack
),
$last
[
0
],
$last
[
2
],
$delta
);
}
ksort
(
$timings
);
$rows
=
array
();
$rows
=
array
();
foreach
(
$timings
as
$timing
)
{
foreach
(
$timings
as
$timing
)
{
$time
=
date
(
'Y.m.d, H:i:s.'
,
$timing
[
2
])
.
round
((
$timing
[
2
]
-
floor
(
$timing
[
2
]))
*
10000
);
$duration
=
sprintf
(
'%.1f ms'
,
$timing
[
3
]
*
1000
);
$duration
=
sprintf
(
'%.1f ms'
,
$timing
[
3
]
*
1000
);
$procedure
=
str_repeat
(
'<span class="indent">→</span>'
,
$timing
[
0
])
.
Html
::
encode
(
$timing
[
1
]);
$procedure
=
str_repeat
(
'<span class="indent">→</span>'
,
$timing
[
0
])
.
Html
::
encode
(
$timing
[
1
]);
$rows
[]
=
"<tr><td style=
\"
width: 80px;
\"
>
$
time
</td><td style=
\"
width: 80px;
\"
>
$
duration
</td><td>
$procedure
</td>"
;
$rows
[]
=
"<tr><td style=
\"
width: 80px;
\"
>
$duration
</td><td>
$procedure
</td>"
;
}
}
$rows
=
implode
(
"
\n
"
,
$rows
);
$rows
=
implode
(
"
\n
"
,
$rows
);
...
@@ -72,7 +60,6 @@ EOD;
...
@@ -72,7 +60,6 @@ EOD;
<table class="table table-condensed table-bordered table-striped table-hover" style="table-layout: fixed;">
<table class="table table-condensed table-bordered table-striped table-hover" style="table-layout: fixed;">
<thead>
<thead>
<tr>
<tr>
<th style="width: 180px;">Time</th>
<th style="width: 80px;">Duration</th>
<th style="width: 80px;">Duration</th>
<th>Query</th>
<th>Query</th>
</tr>
</tr>
...
@@ -84,6 +71,37 @@ $rows
...
@@ -84,6 +71,37 @@ $rows
EOD;
EOD;
}
}
private
$_timings
;
protected
function
calculateTimings
()
{
if
(
$this
->
_timings
!==
null
)
{
return
$this
->
_timings
;
}
$messages
=
$this
->
data
[
'messages'
];
$timings
=
array
();
$stack
=
array
();
foreach
(
$messages
as
$i
=>
$log
)
{
list
(
$token
,
$level
,
$category
,
$timestamp
)
=
$log
;
$log
[
4
]
=
$i
;
if
(
$level
==
Logger
::
LEVEL_PROFILE_BEGIN
)
{
$stack
[]
=
$log
;
}
elseif
(
$level
==
Logger
::
LEVEL_PROFILE_END
)
{
if
((
$last
=
array_pop
(
$stack
))
!==
null
&&
$last
[
0
]
===
$token
)
{
$timings
[
$last
[
4
]]
=
array
(
count
(
$stack
),
$token
,
$last
[
3
],
$timestamp
-
$last
[
3
]);
}
}
}
$now
=
microtime
(
true
);
while
((
$last
=
array_pop
(
$stack
))
!==
null
)
{
$delta
=
$now
-
$last
[
3
];
$timings
[
$last
[
4
]]
=
array
(
count
(
$stack
),
$last
[
0
],
$last
[
2
],
$delta
);
}
ksort
(
$timings
);
return
$this
->
_timings
=
$timings
;
}
public
function
save
()
public
function
save
()
{
{
$target
=
$this
->
module
->
logTarget
;
$target
=
$this
->
module
->
logTarget
;
...
...
framework/yii/debug/panels/RequestPanel.php
View file @
ee994efd
...
@@ -31,11 +31,11 @@ class RequestPanel extends Panel
...
@@ -31,11 +31,11 @@ class RequestPanel extends Panel
return
<<<EOD
return
<<<EOD
<div class="yii-debug-toolbar-block">
<div class="yii-debug-toolbar-block">
<a href="$url">
Peak m
emory: <span class="label">$memory</span></a>
<a href="$url">
M
emory: <span class="label">$memory</span></a>
</div>
</div>
<div class="yii-debug-toolbar-block">
<div class="yii-debug-toolbar-block">
<a href="$url">Time
spent
: <span class="label">$time</span></a>
<a href="$url">Time: <span class="label">$time</span></a>
</div>
</div>
<div class="yii-debug-toolbar-block">
<div class="yii-debug-toolbar-block">
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment